lkml.org 
[lkml]   [2013]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] clk: bcm281xx: define kona clock binding
On 12/04/2013 06:45 AM, Alex Elder wrote:
>>> +Device tree example:
>>> >> +
>>> >> + clocks {
>>> >> + slave_ccu: slave_ccu {
>>> >> + compatible = "brcm,bcm11351-slave-ccu";
>>> >> + reg = <0x3e011000 0x0f00>;
>>> >> + #clock-cells = <1>;
>>> >> + clock-output-names = "uartb",
>>> >> + "uartb2",
>>> >> + "uartb3",
>>> >> + "uartb4";
>>> >> + };
>>> >> + ref_crystal_clk: ref_crystal {
>>> >> + #clock-cells = <0>;
>>> >> + compatible = "fixed-clock";
>>> >> + clock-frequency = <26000000>;
>>> >> + };
>>> >> + };
>> >
>> > This is wrong, as the clocks container node us not defined as any type
>> > of bus, and does not have the requisite #address-cells and #size-cells.
> Sorry, I didn't realize it was wrong. I intentionally used
> it simply for groiuping.

I should have looked at my actual dtsi file before responding.

It turns out that what was shown there was not complete. The
dtsi file in fact does contain #address-cells and #size-cells
(and a direct-mapping "ranges" property).

I have removed the enclosing "clocks" node and its braces in
the document. I have not removed the node from the dtsi file.

-Alex


\
 
 \ /
  Last update: 2013-12-04 17:41    [W:0.069 / U:0.948 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site