Messages in this thread |  | | Date | Wed, 04 Dec 2013 16:09:52 +0200 | From | Adrian Hunter <> | Subject | Re: [PATCH 1/7] perf script: Do not call perf_event__preprocess_sample() twice) |
| |
On 03/12/13 20:23, Arnaldo Carvalho de Melo wrote: > Em Tue, Dec 03, 2013 at 09:23:04AM +0200, Adrian Hunter escreveu: >> perf_event__preprocess_sample() is called in >> process_sample_event(). Instead of calling it >> again in perf_evsel__print_ip(), pass though >> the resultant addr_location. > > <SNIP> >> +++ b/tools/perf/util/session.c >> @@ -1487,11 +1487,12 @@ struct perf_evsel *perf_session__find_first_evtype(struct perf_session *session, >> return NULL; >> } >> >> -void perf_evsel__print_ip(struct perf_evsel *evsel, union perf_event *event, >> +void perf_evsel__print_ip(struct perf_evsel *evsel, >> + union perf_event *event __maybe_unused, > > Why do we have to keep this parameter?
You are right - it is not needed.
|  |