Messages in this thread | | | Date | Wed, 04 Dec 2013 14:16:49 +0100 | From | Olliver Schinagl <> | Subject | Re: [PATCH 2/3] ARM: sunxi: Add an ahci-platform compatible AHCI driver for the Allwinner SUNXi series of SoCs |
| |
On 04-12-13 14:14, Tejun Heo wrote: > Hello, > > On Wed, Dec 04, 2013 at 01:56:23PM +0100, Oliver Schinagl wrote: >> I took the imx driver as example, as I wasn't sure on where to >> start. But I don't think it's possible yet without improving >> ahci_platform as I suggested in the cover letter. So if >> ahci_platform needs to be improved, I guess a separate patch series >> would be more appropriate? >> >> So would it be acceptable to have this as the 2nd (and last?) >> ahci_platform driver and go from there? Or do you want to block new >> ahci_XXX drivers until ahci_platform has been improved? > > I don't want to block new drivers unconditionally but at least I want > to know which direction we're headed in the longer term. Right now it > feels like we could be at the beginning of an uncoordinated explosion > of these drivers which will take a hell lot mpore effort to clean up > after the fact. I could be wrong and these could actually be > different enough to justify separate drivers and there isn't gonna be > an avalanche of these but again I at least want to know the general > direction things are headed before making any decisions. I'd be happy to pour it in any form that's needed. I even do the modification/rewrite of ahci_platform if I get enough help as it might be a little over my head initially ;)
That said, I don't think it's much different at all and I do think it could be much simpler. In my mind, the sunxi_ahci driver wouldn't need to be much bigger then a few lines that are specific to the SoC (hardware init) and registerd to the ahci_platform framework via platform_ahci_register() instead of platform_device_register().
But again, point me (for dummies ;) in the right direction and I'll work on it with some help.
Oliver > > Thanks. >
| |