lkml.org 
[lkml]   [2013]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] usb: chipidea: msm: Add device tree binding information
On Wed, Dec 04, 2013 at 10:33:57AM +0200, Ivan T. Ivanov wrote:
> Hi Peter,
>
> Thank you for reviewing this patch.
>
> On Wed, 2013-12-04 at 13:40 +0800, Peter Chen wrote:
> > On Mon, Nov 11, 2013 at 03:35:34PM +0200, Ivan T. Ivanov wrote:
> > > From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
> > >
> >
> > Please add something in commit log
> >
> > > Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com>
> > > Cc: devicetree@vger.kernel.org
> > > ---
> > > .../devicetree/bindings/usb/msm-hsusb.txt | 16 ++++++++++++++++
> > > 1 file changed, 16 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/usb/msm-hsusb.txt b/Documentation/devicetree/bindings/usb/msm-hsusb.txt
> > > index 5ea26c6..0a85eba 100644
> > > --- a/Documentation/devicetree/bindings/usb/msm-hsusb.txt
> > > +++ b/Documentation/devicetree/bindings/usb/msm-hsusb.txt
> > > @@ -15,3 +15,19 @@ Example EHCI controller device node:
> > > usb-phy = <&usb_otg>;
> > > };
> > >
> > > +CI13xxx (Chipidea) USB controllers
> > > +
> >
> > We have already renamed ci13xxx to ci_hdrc.
>
> Yes, but the chip is still CI13XXX. Freescale documentations is also
> referring to actual chip family.

OK, let's keep IP reference at doc. I will change the Freescale doc
name from ci13xxx-imx.txt to ci-hdrc-imx.txt

>
> >
> > > +Required properties:
> > > +- compatible: should contain "qcom,ci-hdrc"
> > > +- reg: offset and length of the register set in the memory map
> > > +- interrupts: interrupt-specifier for the controller interrupt.
> > > +- usb-phy: phandle for the PHY device
> > > +- dr_mode: Sould be "peripheral"
> > > +
> >
> > Please keep alignment for "reg"
> >
>
> It looks aligned in editor with smart-tab support.
>

OK, let's keep it

--

Best Regards,
Peter Chen



\
 
 \ /
  Last update: 2013-12-04 15:01    [W:0.047 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site