lkml.org 
[lkml]   [2013]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] perf report: Add --show-time-info option

* Arnaldo Carvalho de Melo <acme@ghostprotocols.net> wrote:

> Em Mon, Dec 02, 2013 at 12:58:35PM -0700, David Ahern escreveu:
> > On 12/2/13, 12:38 PM, Arnaldo Carvalho de Melo wrote:
> > >Can you suggest a better name for the option being discussed?
>
> > >Perhaps one of:
>
> > >--show-event-time
> > >--event-time
>
> > >?
> >
> > Why not just --event-time?
>
>
> > Really should have dropped the 'show' from the recent perf-script
> > change (just --task-events and --mmap-events).
>
> Probably, yeah, Ingo made some point about using --show- for some reason,
> Ingo?

So the reason for my suggestion was that I've noticed a proliferation
of such flags in perf report. To reduce namespace pollution it's
always good to bring a certain kind of hierarchy into command line
options.

Options that work alike should spell alike. Users shouldn't be
required to memorize every naming quirk of the various disjunct
'display this extra data' options.

So if we expect more --show options in the future (and in particular
if there are existing oddball options that could be changed to the
--show-xyz pattern) then I'd suggest to do it unified. For example
there's --show-nr-samples and --show-info already which follows this
pattern.

This pattern would distinguish this option from the other perf report
options, such as --vmlinux, --force, --sort, etc.

It might even make sense to unify it all into a single --show option.
That would allow the following current mismash of options:

--task-events --mmap-events --show-nr-samples --show-info

to be replaced by a much more obvious, much more coherent looking
option sequence:

--show task-events,mmap-events,nr-samples,info

an added bonus would be that '--show help' could be implemented as
well, to list all displayable extra data.

(I'm not married to the specific naming, it could be something else as
well, like --display or --report.)

Or something like that.

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-12-04 14:41    [W:0.048 / U:2.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site