Messages in this thread |  | | Subject | Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up. | From | Ian Campbell <> | Date | Wed, 4 Dec 2013 13:06:36 +0000 |
| |
On Wed, 2013-12-04 at 13:00 +0000, David Vrabel wrote: > On 03/12/13 21:14, Konrad Rzeszutek Wilk wrote: > > > > Ian Campbell suggested getting rid of 'xen_platform_pci_unplug' > > but unfortunatly the xen-blkfront driver is using it, so we > > cannot do it. > > I had a look at what blkfront was using this for and it seems dumb. How > did we end up with the frontend driver working around toolstack bugs? > If HVM Linux guest didn't want (e.g.,) PV CDROM, the toolstack shouldn't > have created one.
Note that this cdrom stuff is actually nothing to do with the unplug variable -- it just happens to be right next to that check.
Not that the use of the unplug var there doesn't also look pretty odd...
|  |