Messages in this thread | | | Date | Wed, 4 Dec 2013 15:56:47 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] Staging: bcm: DDRInit: Fixed non_standard kernel style. |
| |
On Wed, Dec 04, 2013 at 04:53:09AM -0500, Gary Rookard wrote: > Fixed non_standard kernel style. >
You're doing too many things at once, it needs to be broken into a patch series which do one type of change at a time.
The changelog is useless.
> Signed off by: Gary Alan Rookard <garyrookard@gmail.com> > --- > drivers/staging/bcm/DDRInit.c | 2081 +++++++++++++++++++---------------------- > 1 file changed, 977 insertions(+), 1104 deletions(-) > > diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c > index 9f7e30f..2fc3ba9 100644 > --- a/drivers/staging/bcm/DDRInit.c > +++ b/drivers/staging/bcm/DDRInit.c > @@ -1,977 +1,876 @@ > -#include "headers.h" > - > +/* File: DDRInit.c */
This isn't useful.
> + {0x0F000840, 0x0FFF1B00}, /* Changed Source for X-bar and MIPS Clock to APLL */ > + {0xF0000870, 0x00000002}, > + {0x0F00A044, 0x1FFFFFFF}, > + {0x0F00A040, 0x1F000000},
One of these is not like the others. You have introduced a bug with 0xF0000870 vs 0x0F000870.
regards, dan carpenter
| |