Messages in this thread |  | | Date | Wed, 4 Dec 2013 07:37:08 -0500 | From | Tejun Heo <> | Subject | Re: [PATCH 2/3] ARM: sunxi: Add an ahci-platform compatible AHCI driver for the Allwinner SUNXi series of SoCs |
| |
On Wed, Dec 04, 2013 at 01:10:54PM +0100, oliver@schinagl.nl wrote: > From: Oliver Schinagl <oliver@schinagl.nl> > > This patch adds support for the sunxi series of SoC's by allwinner. It > plugs into the ahci-platform framework. > > Note: Currently it uses a somewhat hackish approach that probably needs > a lot more work, but does the same as the IMX SoC's. > > Signed-off-by: Olliver Schinagl <oliver@schinagl.nl> > --- > .../devicetree/bindings/ata/ahci-sunxi.txt | 24 ++ > drivers/ata/Kconfig | 9 + > drivers/ata/Makefile | 1 + > drivers/ata/ahci_platform.c | 12 + > drivers/ata/ahci_sunxi.c | 305 +++++++++++++++++++++
I'm not really liking the way things are going. Do we really need separate drivers for each platform ahci implementation. Are they really that different? Would it be impossible to make ahci_platform generic enough so that we don't eventually end up with a gazillion ahci_XXX drivers?
-- tejun
|  |