lkml.org 
[lkml]   [2013]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2 RESEND] irqchip: Add support for TI-NSPIRE irqchip
On Mon, 25 Nov 2013, dt.tangr@gmail.com wrote:
> diff --git a/drivers/irqchip/irq-zevio.c b/drivers/irqchip/irq-zevio.c
> +static void zevio_irq_ack(struct irq_data *irqd)
> +{
> + struct irq_chip_generic *gc = irq_data_get_irq_chip_data(irqd);
> + struct irq_chip_regs *regs =
> + &container_of(irqd->chip, struct irq_chip_type, chip)->regs;
> +
> + irq_gc_lock(gc);

Why do you need to lock here? You are reading the ack register and not
modifying it. You are neither storing the value in the gc itself. So
what are you trying to protect?

> + readl(gc->reg_base + regs->ack);
> + irq_gc_unlock(gc);
> +}
> +
> +static void init_base(void __iomem *base)

Shouldnt that be marked __init ?

> +{
> + /* Disable all interrupts */
> + writel(~0, base + IO_DISABLE);

Thanks,

tglx


\
 
 \ /
  Last update: 2013-12-04 12:01    [W:0.107 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site