Messages in this thread |  | | From | Ramkumar Ramachandra <> | Date | Wed, 4 Dec 2013 15:40:25 +0530 | Subject | Re: [PATCH v4 2/3] perf diff: color the Ratio column |
| |
Arnaldo Carvalho de Melo wrote: > static inline percent_color_snprintf(...) > { > return value_color_snprintf(...); > }
The issue with this suggestion is that the prototype of percent_color_snprintf() is:
int percent_color_snprintf(char *bf, size_t size, const char *fmt, ...)
So, I can only pass value_color_snprintf() a va_list, making its prototype:
int value_color_snprintf(char *bf, size_t size, const char *fmt, va_list args)
Is this worth the minor rename?
On a related note, does percent_color_snprintf() need to be a variadic function? It only seems to process one percent value.
|  |