[lkml]   [2013]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v4 2/3] perf diff: color the Ratio column
Arnaldo Carvalho de Melo wrote:
> static inline percent_color_snprintf(...)
> {
> return value_color_snprintf(...);
> }

The issue with this suggestion is that the prototype of
percent_color_snprintf() is:

int percent_color_snprintf(char *bf, size_t size, const char *fmt, ...)

So, I can only pass value_color_snprintf() a va_list, making its prototype:

int value_color_snprintf(char *bf, size_t size, const char *fmt, va_list args)

Is this worth the minor rename?

On a related note, does percent_color_snprintf() need to be a variadic
function? It only seems to process one percent value.

 \ /
  Last update: 2013-12-04 11:41    [W:0.056 / U:1.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site