Messages in this thread | | | Date | Wed, 4 Dec 2013 10:03:36 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] perf/x86: fix bug in event constraint end marker macro |
| |
* Stephane Eranian <eranian@google.com> wrote:
> #define EVENT_CONSTRAINT_END \ > - EVENT_CONSTRAINT(0, 0, 0) > + { .idxmsk64 = 0, \ > + .code = 0, \ > + .cmask = 0, \ > + .weight = -1, \ > + .overlap = 0, \ > + .flags = 0, \ > +}
A nit, simply writing:
#define EVENT_CONSTRAINT_END { .weight = -1, }
... should be enough as initialization to zero is guaranteed for the other fields.
Thanks,
Ingo
| |