lkml.org 
[lkml]   [2013]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH RFC] mm readahead: Fix the readahead fail in case of empty numa node
    On 12/04/2013 02:11 PM, Andrew Morton wrote:
    > On Wed, 04 Dec 2013 14:00:09 +0530 Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com> wrote:
    >
    >> Unfaortunately, from my search, I saw that the code belonged to pre git
    >> time, so could not get much information on that.
    >
    > Here: https://lkml.org/lkml/2004/8/20/242
    >
    > It seems it was done as a rather thoughtless performance optimisation.
    > I'd say it's time to reimplement max_sane_readahead() from scratch.
    >

    Ok. Thanks for the link. I think after that,
    Here it was changed to pernode:
    https://lkml.org/lkml/2004/8/21/9 to avoid iteration all over.

    do you think above patch (+comments) with some sanitized nr (thus
    avoiding iteration over nodes in remote numa readahead case) does look
    better?
    or should we iterate all memory.






    \
     
     \ /
      Last update: 2013-12-04 10:21    [W:2.508 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site