lkml.org 
[lkml]   [2013]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Regression due to 0c44c2d0f459 x86: Use asm goto to implement better modify_and_test() functions

* H. Peter Anvin <hpa@zytor.com> wrote:

> Hi guys,
>
> 0c44c2d0f459 x86: Use asm goto to implement better modify_and_test()
> functions
>
> causes a regression, because it incorrectly changed the constraints of
> bitops.
>
> Specifically, the GEN_BINARY_RMWcc() hardcodes a constraint as "er", but
> it needs to be "Ir" for the bitops themselves. "I" is correct (as
> opposed to "J" even on 64 bits, because we only generate the 64-bit
> version when we have a register operand.
>
> Unfortunately there isn't a way we can get gcc+gas to generate a version
> with an offset pointer.

Does the regression manifest itself in any actual breakage - if yes,
how does it look like? (People experiencing similar symptoms will be
helped by seeing a fix matching their problems.)

Thanks,

ngo


\
 
 \ /
  Last update: 2013-12-04 10:21    [W:0.445 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site