Messages in this thread |  | | Date | Tue, 3 Dec 2013 14:01:47 -0800 | Subject | Re: [PATCH?] uprobes: change uprobe_write_opcode() to modify the page directly | From | Linus Torvalds <> |
| |
On Tue, Dec 3, 2013 at 12:54 PM, Oleg Nesterov <oleg@redhat.com> wrote: > > So do you think the patch I sent is wrong? Why?
I think the TLB shootdown should guarantee that it's ok on other CPU's, since that's basically what we do on mmap.
But looking closer at this, I think I see why the old code did what it did. I think it's breaking shared mmap pages on purpose rather than dirtying them. Which is probably the right thing to do.
Linus
|  |