lkml.org 
[lkml]   [2013]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: sysfs: use a separate locking class for open files depending on mmap
Hey,

On Tue, Dec 03, 2013 at 04:15:15PM -0500, Dave Jones wrote:
> > > Somehow I just triggered this trace again, even with this commit applied.
> > > The trace is pretty much identical to the old one.
> >
> > Hah, ain't that weird. That's the trace you reported on the other
> > mail, right? I'll follow up on that one.
>
> just so there's no doubt, here's a fresh one.

Argh, found the culprit. The unified mmap path grabs of->mutex to
check whether the file implements mmap, which means that if you try to
mmap a file which doesn't implement mmap, you still add the locking
dependency. I'm working on the fix.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2013-12-03 22:41    [W:0.069 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site