lkml.org 
[lkml]   [2013]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC part1 PATCH 3/7] ACPI / processor_core: Rework _PDC related stuff to make it more arch-independent
    On Wed, Dec 04, 2013 at 12:36:47AM +0800, Hanjun Guo wrote:

    > +#if defined(CONFIG_X86) || defined(CONFIG_IA64)
    > /* Enable coordination with firmware's _TSD info */
    > buf[2] = ACPI_PDC_SMP_T_SWCOORD;
    > + if (boot_option_idle_override == IDLE_NOMWAIT) {
    > + /*
    > + * If mwait is disabled for CPU C-states, the C2C3_FFH access
    > + * mode will be disabled in the parameter of _PDC object.
    > + * Of course C1_FFH access mode will also be disabled.
    > + */
    > + buf[2] &= ~(ACPI_PDC_C_C2C3_FFH | ACPI_PDC_C_C1_FFH);
    > +
    > + }
    > +#endif

    This is (fairly) arch-specific, so why not move it to
    arch_acpi_set_pdc_bits()?

    --
    Matthew Garrett | mjg59@srcf.ucam.org


    \
     
     \ /
      Last update: 2013-12-03 19:21    [W:4.539 / U:0.196 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site