Messages in this thread | | | Date | Tue, 3 Dec 2013 18:01:50 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH] x86: mcheck: call put_device on device_register failure |
| |
Can you please fix your
Mail-Followup-To:
header? It is impossible to reply to your emails without fiddling with the To: and Cc: by hand which gets very annoying over time.
On Mon, Dec 02, 2013 at 09:23:30PM -0500, Chen, Gong wrote: > I have some concerns about it. if device_register is failed, it will > backtraces all kinds of conditions automatically, including put_device > definately. So do we really need an extra put_device when it returns > failure?
Do you mean the "done:" label in device_add() which does put_device() and which gets called by device_register()?
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |