Messages in this thread | | | From | Ramkumar Ramachandra <> | Date | Sun, 29 Dec 2013 15:44:38 +0530 | Subject | Re: [PATCH v5 3/3] perf diff: color the Weighted Diff column |
| |
Jiri Olsa wrote: > this one is still wrong, you either need to use 'abs(wdiff) > 0' > or call value_color_snprintf (which is better) as in previous cases
This was very much intentional on my part (see commit message): I thought it would be nicer to color it this way because all the numbers tend to be large. However, I'll resubmit with value_color_snprintf() now.
p.s- Sorry about the terribly late response; was on vacation.
| |