lkml.org 
[lkml]   [2013]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 090/185] mac80211: don't attempt to reorder multicast frames
    3.2.54-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johannes Berg <johannes.berg@intel.com>

    commit 051a41fa4ee14f5c39668f0980973b9a195de560 upstream.

    Multicast frames can't be transmitted as part of an aggregation
    session (such a session couldn't even be set up) so don't try to
    reorder them. Trying to do so would cause the reorder to stop
    working correctly since multicast QoS frames (as transmitted by
    the Aruba APs this was found with) would cause sequence number
    confusion in the buffer.

    Reported-by: Blaise Gassend <blaise@suitabletech.com>
    Signed-off-by: Johannes Berg <johannes.berg@intel.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    net/mac80211/rx.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/net/mac80211/rx.c
    +++ b/net/mac80211/rx.c
    @@ -764,7 +764,8 @@ static void ieee80211_rx_reorder_ampdu(s
    u16 sc;
    int tid;

    - if (!ieee80211_is_data_qos(hdr->frame_control))
    + if (!ieee80211_is_data_qos(hdr->frame_control) ||
    + is_multicast_ether_addr(hdr->addr1))
    goto dont_reorder;

    /*


    \
     
     \ /
      Last update: 2013-12-29 05:01    [W:4.020 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site