lkml.org 
[lkml]   [2013]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 018/185] powerpc/vio: use strcpy in modalias_show
    3.2.54-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Prarit Bhargava <prarit@redhat.com>

    commit 411cabf79e684171669ad29a0628c400b4431e95 upstream.

    Commit e82b89a6f19bae73fb064d1b3dd91fcefbb478f4 used strcat instead of
    strcpy which can result in an overflow of newlines on the buffer.

    Signed-off-by: Prarit Bhargava
    Cc: benh@kernel.crashing.org
    Cc: ben@decadent.org.uk
    Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    arch/powerpc/kernel/vio.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/arch/powerpc/kernel/vio.c
    +++ b/arch/powerpc/kernel/vio.c
    @@ -1352,12 +1352,12 @@ static ssize_t modalias_show(struct devi

    dn = dev->of_node;
    if (!dn) {
    - strcat(buf, "\n");
    + strcpy(buf, "\n");
    return strlen(buf);
    }
    cp = of_get_property(dn, "compatible", NULL);
    if (!cp) {
    - strcat(buf, "\n");
    + strcpy(buf, "\n");
    return strlen(buf);
    }



    \
     
     \ /
      Last update: 2013-12-29 04:41    [W:4.056 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site