Messages in this thread | | | From | Michael Dalton <> | Date | Wed, 25 Dec 2013 10:33:37 -0800 | Subject | Re: [PATCH stable 1/2] virtio_net: fix error handling for mergeable buffers |
| |
Hi Michael, quick question below:
On Wed, Dec 25, 2013 at 6:56 AM, Michael S. Tsirkin <mst@redhat.com> wrote: > if (i >= MAX_SKB_FRAGS) { > pr_debug("%s: packet too long\n", skb->dev->name); > skb->dev->stats.rx_length_errors++; > - return -EINVAL; > + return NULL; > }
Should this error handling path free the SKB before returning NULL? It seems like if we just return NULL we may leak memory.
Best,
Mike
| |