lkml.org 
[lkml]   [2013]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRe: [PATCH -tip 1/3] [CLEANUP] perf-probe: Expand given path to absolute path
    Date
    Hi Masami,

    On Fri, 20 Dec 2013 10:02:57 +0000, Masami Hiramatsu wrote:
    > Expand given path to absolute path in option parser,
    > except for a module name. Instead of expanding it later,
    > this get the absolute path in early stage.
    >
    > Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
    > ---
    > tools/perf/builtin-probe.c | 9 +++++++++
    > tools/perf/util/probe-event.c | 11 ++---------
    > 2 files changed, 11 insertions(+), 9 deletions(-)
    >
    > diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
    > index 6ea9e85..b40d064 100644
    > --- a/tools/perf/builtin-probe.c
    > +++ b/tools/perf/builtin-probe.c
    > @@ -180,6 +180,15 @@ static int opt_set_target(const struct option *opt, const char *str,
    > else
    > return ret;
    >
    > + /* Expand given path to absolute path, except for modulename */
    > + if (params.uprobes || strchr(str, '/')) {
    > + str = realpath(str, NULL);
    > + if (!str) {
    > + pr_warning("Failed to find the path of %s.\n",
    > + str);

    It won't print the path since the str already was overwritten to NULL.


    > + return ret;
    > + }
    > + }
    > params.target = str;

    It now points either a dynamically allocated string or not..

    Thanks,
    Namhyung

    > ret = 0;
    > }


    \
     
     \ /
      Last update: 2013-12-23 07:41    [W:3.435 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site