Messages in this thread |  | | Date | Mon, 23 Dec 2013 10:48:58 -0600 | From | Felipe Balbi <> | Subject | Re: [PATCH v2 1/4] phy: Add new Exynos5 USB 3.0 PHY driver |
| |
Hi,
On Mon, Dec 23, 2013 at 02:41:15PM +0530, Vivek Gautam wrote: > On Wed, Dec 4, 2013 at 3:39 PM, Vivek Gautam <gautam.vivek@samsung.com> wrote: > > Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. > > The new driver uses the generic PHY framework and will interact > > with DWC3 controller present on Exynos5 series of SoCs. > > Thereby, removing old phy-samsung-usb3 driver and related code > > used untill now which was based on usb/phy framework. > > > > Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> > > --- > > a humble ping !! :-) > Any comments on this patch ?
This is Kishon's domain. I think he's on vacations by now...
> > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > > index a344f3d..67e9045 100644 > > --- a/drivers/phy/Kconfig > > +++ b/drivers/phy/Kconfig > > @@ -51,4 +51,12 @@ config PHY_EXYNOS_DP_VIDEO > > help > > Support for Display Port PHY found on Samsung EXYNOS SoCs. > > > > +config PHY_EXYNOS5_USB3 > > + tristate "Exynos5 SoC series USB 3.0 PHY driver" > > + depends on ARCH_EXYNOS5
I would add || COMPILE_TEST here and make sure this builds on other arches too.
The rest of the driver looks all right to my eyes.
Reviewed-by: Felipe Balbi <balbi@ti.com>
-- balbi [unhandled content-type:application/pgp-signature] |  |