lkml.org 
[lkml]   [2013]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH -next] Re: randconfig build error with next-20131210, in drivers/crypto/ccp/ccp-pci.c
Date

On Thursday, December 19, 2013 11:35:09 AM Randy Dunlap wrote:
> On 12/10/13 07:34, Tom Lendacky wrote:
> >
> > On Tuesday, December 10, 2013 07:21:36 AM Jim Davis wrote:
> >> Building with the attached random configuration file,
> >>
> >> drivers/crypto/ccp/ccp-pci.c: In function ‘ccp_get_msix_irqs’:
> >> drivers/crypto/ccp/ccp-pci.c:44:20: error: array type has incomplete
> >> element type
> >> drivers/crypto/ccp/ccp-pci.c:48:18: error: negative width in bit-field
> >> ‘<anonymous>’
> >> drivers/crypto/ccp/ccp-pci.c:51:2: error: implicit declaration of
> >> function ‘pci_enable_msix’ [-Werror=implicit-function-declaration]
> >> drivers/crypto/ccp/ccp-pci.c:76:2: error: implicit declaration of
> >> function ‘pci_disable_msix’ [-Werror=implicit-function-declaration]
> >> drivers/crypto/ccp/ccp-pci.c:44:20: warning: unused variable
> >> ‘msix_entry’ [-Wunused-variable]
> >> drivers/crypto/ccp/ccp-pci.c: In function ‘ccp_get_msi_irq’:
> >> drivers/crypto/ccp/ccp-pci.c:89:2: error: implicit declaration of
> >> function ‘pci_enable_msi’ [-Werror=implicit-function-declaration]
> >> drivers/crypto/ccp/ccp-pci.c:102:2: error: implicit declaration of
> >> function ‘pci_disable_msi’ [-Werror=implicit-function-declaration]
> >> cc1: some warnings being treated as errors
> >> make[3]: *** [drivers/crypto/ccp/ccp-pci.o] Error 1
> >
> > Thanks for finding this, I'll update to the Kconfig to add PCI to
> > the 'depends on' statement.
>
> Tom,
>
> Can you get this patch and the HW_RANDOM patch merged into linux-next, please?
> linux-next builds are still failing for both of these reasons.

Please consider the following patch that addresses some randconfig
build errors being experienced in the linux-next tree. This patch
has already been accepted in the cryptodev-2.6 tree with a commit
id of d5aa80952aba9071b50a74c8daf7feb1caa2fd8c.

---
From: Tom Lendacky <thomas.lendacky@amd.com>

crypto: ccp - CCP Kconfig fixes

Update the Kconfig to include PCI on the 'depends on'
and add 'select HW_RANDOM' to insure the necessary PCI
and HW_RANDOM functions are available/included in the
build.

Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
---
drivers/crypto/Kconfig | 2 +-
drivers/crypto/ccp/Kconfig | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 4954d75..9dee00f 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -401,7 +401,7 @@ config CRYPTO_DEV_ATMEL_SHA

config CRYPTO_DEV_CCP
bool "Support for AMD Cryptographic Coprocessor"
- depends on X86
+ depends on X86 && PCI
default n
help
The AMD Cryptographic Coprocessor provides hardware support
diff --git a/drivers/crypto/ccp/Kconfig b/drivers/crypto/ccp/Kconfig
index 335ed5c..7639ffc 100644
--- a/drivers/crypto/ccp/Kconfig
+++ b/drivers/crypto/ccp/Kconfig
@@ -2,6 +2,7 @@ config CRYPTO_DEV_CCP_DD
tristate "Cryptographic Coprocessor device driver"
depends on CRYPTO_DEV_CCP
default m
+ select HW_RANDOM
help
Provides the interface to use the AMD Cryptographic Coprocessor
which can be used to accelerate or offload encryption operations

>
> thanks,
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2013-12-20 16:41    [W:0.270 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site