lkml.org 
[lkml]   [2013]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 114/173] ALSA: hda - Fix hp-mic mode without VREF bits
    Date
    3.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Takashi Iwai <tiwai@suse.de>

    commit 16c0cefe8951b2c4b824fd06011ac1b359b1ab3b upstream.

    When the hp mic pin has no VREF bits, the driver forgot to set PIN_IN
    bit. Spotted during debugging old MacBook Airs.

    Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=65681
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/pci/hda/hda_generic.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/sound/pci/hda/hda_generic.c
    +++ b/sound/pci/hda/hda_generic.c
    @@ -2703,7 +2703,7 @@ static int hp_mic_jack_mode_put(struct s
    val &= ~(AC_PINCTL_VREFEN | PIN_HP);
    val |= get_vref_idx(vref_caps, idx) | PIN_IN;
    } else
    - val = snd_hda_get_default_vref(codec, nid);
    + val = snd_hda_get_default_vref(codec, nid) | PIN_IN;
    }
    snd_hda_set_pin_ctl_cache(codec, nid, val);
    call_hp_automute(codec, NULL);



    \
     
     \ /
      Last update: 2013-12-02 22:01    [W:2.803 / U:0.880 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site