lkml.org 
[lkml]   [2013]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 048/212] rtlwifi: rtl8188ee: Fix smatch warning in rtl8188ee/hw.c
    Date
    3.12-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Larry Finger <Larry.Finger@lwfinger.net>

    commit dab3df5e88b979f8d09860f873ccfaa7a55758d2 upstream.

    Smatch lists the following:
    CHECK drivers/net/wireless/rtlwifi/rtl8188ee/hw.c
    drivers/net/wireless/rtlwifi/rtl8188ee/hw.c:149 _rtl88ee_set_fw_clock_on() info: ignoring unreachable code.
    drivers/net/wireless/rtlwifi/rtl8188ee/hw.c:149 _rtl88ee_set_fw_clock_on() info: ignoring unreachable code.

    This info message is the result of a real error due to a missing break statement
    in a "while (1)" loop.

    Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/wireless/rtlwifi/rtl8188ee/hw.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/net/wireless/rtlwifi/rtl8188ee/hw.c
    +++ b/drivers/net/wireless/rtlwifi/rtl8188ee/hw.c
    @@ -143,6 +143,7 @@ static void _rtl88ee_set_fw_clock_on(str
    } else {
    rtlhal->fw_clk_change_in_progress = false;
    spin_unlock_bh(&rtlpriv->locks.fw_ps_lock);
    + break;
    }
    }




    \
     
     \ /
      Last update: 2013-12-02 21:41    [W:5.316 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site