Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCHv3 20/29] tools lib traceevent: Remove malloc_or_die from plugin_function.c | Date | Mon, 02 Dec 2013 17:29:52 +0900 |
| |
On Fri, 29 Nov 2013 13:42:49 +0100, Jiri Olsa wrote: > On Fri, Nov 29, 2013 at 10:54:21AM +0000, Namhyung Kim wrote: >> > Removing malloc_or_die calls from plugin_function.c, >> > replacing them and factoring the code with standard >> > realloc and error path. >> >> [SNIP] >> > >> > if (cpu > cpus) { >> > - if (fstack) >> > - fstack = realloc(fstack, sizeof(*fstack) * (cpu + 1)); >> > - else >> > - fstack = malloc_or_die(sizeof(*fstack) * (cpu + 1)); >> > + fstack = realloc(fstack, sizeof(*fstack) * (cpu + 1)); >> >> This code also has same problem.. >> > > and v3.1 ;-) thanks
Thank you for your effort.
Now the whole series looks all good to me (with other changes fixed).
Thanks, Namhyung
| |