lkml.org 
[lkml]   [2013]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 116/212] tty: incorrect test of echo_buf() result for ECHO_OP_START
    Date
    3.12-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Roel Kluin <roel.kluin@gmail.com>

    commit c476f6584b0011741b4f0316f1ac4aa3a99403e1 upstream.

    test echo_buf() result for ECHO_OP_START

    Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
    Acked-by: Peter Hurley <peter@hurleysoftware.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/tty/n_tty.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/tty/n_tty.c
    +++ b/drivers/tty/n_tty.c
    @@ -767,7 +767,7 @@ static size_t __process_echoes(struct tt
    * of echo overrun before the next commit), then discard enough
    * data at the tail to prevent a subsequent overrun */
    while (ldata->echo_commit - tail >= ECHO_DISCARD_WATERMARK) {
    - if (echo_buf(ldata, tail == ECHO_OP_START)) {
    + if (echo_buf(ldata, tail) == ECHO_OP_START) {
    if (echo_buf(ldata, tail) == ECHO_OP_ERASE_TAB)
    tail += 3;
    else



    \
     
     \ /
      Last update: 2013-12-02 20:41    [W:3.320 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site