lkml.org 
[lkml]   [2013]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/17] tracing/probes: Split [ku]probes_fetch_type_table
On 11/27, Namhyung Kim wrote:
>
> Use separate fetch_type_table for kprobes and uprobes. It currently
> shares all fetch methods but some of them will be implemented
> differently later.

Hmm. This looks wrong, afaics...

> static int parse_probe_arg(char *arg, const struct fetch_type *t,
> struct fetch_param *f, bool is_return, bool is_kprobe)
> {
> + const struct fetch_type *ftbl;
> unsigned long param;
> long offset;
> char *tmp;
> - int ret;
> + int ret = 0;
>
> - ret = 0;
> + ftbl = is_kprobe ? kprobes_fetch_type_table : uprobes_fetch_type_table;

OK, but what if, say, CONFIG_KPROBE_EVENT && !CONFIG_UPROBE_EVENT ?
The kernel won't compile in this case?

Oleg.



\
 
 \ /
  Last update: 2013-12-02 18:21    [W:1.438 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site