Messages in this thread | | | Date | Mon, 2 Dec 2013 21:10:18 +0800 | Subject | Re: [PATCH 00/12] Thunderbolt hotplug support for Apple hardware (testers needed) | From | Daniel J Blueman <> |
| |
On 2 December 2013 18:53, Andreas Noever <andreas.noever@gmail.com> wrote: > On Mon, Dec 2, 2013 at 3:51 AM, Daniel J Blueman <daniel@quora.org> wrote: >> On Friday, 29 November 2013 09:40:02 UTC+8, Andreas Noever wrote: >> >> Booting with 3.12.2, your patch series, with acpi_osi=Darwin and no >> thunderbolt devices plugged, I run into this oops: > > Ahh, I should have put a warning (since I spend about 3 hours to > figure that out when updating from 3.12 to 3.13): > 3.13 contains http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=498d319bb512992ef0784c278fa03679f2f5649d > which means that kfifo_put now takes a value instead of a pointer. To > run the driver on 3.12 try changing the kfifo_put in > tb_ctl.c:tb_ctl_rx_callback to: > if (!kfifo_put(&cfg->response_fifo, &pkg)) {
Suspend issues aside, this works perfectly with 3.12 booted with acpi_osi=Darwin in both thunderbolt ports with the Apple ethernet adapter and my Buffalo MiniStation.
Great work!
Daniel -- Daniel J Blueman
| |