Messages in this thread |  | | Date | Mon, 2 Dec 2013 19:33:35 +0900 | From | Alex Courbot <> | Subject | Re: [PATCH] gpio: better lookup method for platform GPIOs |
| |
On 11/29/2013 08:57 PM, Heikki Krogerus wrote: > Hi, > > On Thu, Nov 28, 2013 at 05:46:28PM +0900, Alexandre Courbot wrote: >> @@ -88,16 +89,20 @@ Note that GPIO_LOOKUP() is just a shortcut to GPIO_LOOKUP_IDX() where idx = 0. >> >> A lookup table can then be defined as follows: >> >> - struct gpiod_lookup gpios_table[] = { >> - GPIO_LOOKUP_IDX("gpio.0", 15, "foo.0", "led", 0, GPIO_ACTIVE_HIGH), >> - GPIO_LOOKUP_IDX("gpio.0", 16, "foo.0", "led", 1, GPIO_ACTIVE_HIGH), >> - GPIO_LOOKUP_IDX("gpio.0", 17, "foo.0", "led", 2, GPIO_ACTIVE_HIGH), >> - GPIO_LOOKUP("gpio.0", 1, "foo.0", "power", GPIO_ACTIVE_LOW), >> - }; >> +struct gpiod_lookup_table gpios_table = { >> + .dev_id = "foo.0", >> + .size = 4, >> + .table = { >> + GPIO_LOOKUP_IDX("gpio.0", 15, "led", 0, GPIO_ACTIVE_HIGH), >> + GPIO_LOOKUP_IDX("gpio.0", 16, "led", 1, GPIO_ACTIVE_HIGH), >> + GPIO_LOOKUP_IDX("gpio.0", 17, "led", 2, GPIO_ACTIVE_HIGH), >> + GPIO_LOOKUP("gpio.0", 1, "power", GPIO_ACTIVE_LOW), >> + }, >> +}; > > Instead of using the size variable, wouldn't it be more clear to > expect the array to be null terminated?
This is a zero-length array, its entries are not pointers but flattened lookup entries. Thus you cannot simply null-terminate it. It would be possible to use { NULL } as a terminator, but this would expand into a whole gpiod_lookup and is not very pleasant esthetically-speaking. So I think the size member is maybe better suited here.
|  |