lkml.org 
[lkml]   [2013]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 175/212] GFS2: Fix ref count bug relating to atomic_open
    Date
    3.12-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Steven Whitehouse <swhiteho@redhat.com>

    commit ea0341e071527d5cec350917b01ab901af09d758 upstream.

    In the case that atomic_open calls finish_no_open() with
    the dentry that was supplied to gfs2_atomic_open() an
    extra reference count is required. This patch fixes that
    issue preventing a bug trap triggering at umount time.

    Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/gfs2/inode.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    --- a/fs/gfs2/inode.c
    +++ b/fs/gfs2/inode.c
    @@ -1168,8 +1168,11 @@ static int gfs2_atomic_open(struct inode
    if (d != NULL)
    dentry = d;
    if (dentry->d_inode) {
    - if (!(*opened & FILE_OPENED))
    + if (!(*opened & FILE_OPENED)) {
    + if (d == NULL)
    + dget(dentry);
    return finish_no_open(file, dentry);
    + }
    dput(d);
    return 0;
    }



    \
     
     \ /
      Last update: 2013-12-03 07:41    [W:4.927 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site