Messages in this thread | | | Date | Thu, 19 Dec 2013 23:54:13 -0500 | From | Richard Guy Briggs <> | Subject | Re: [PATCH 11/12] pid: rewrite task helper functions avoiding task->pid and task->tgid |
| |
On 13/12/17, Peter Zijlstra wrote: > On Mon, Dec 16, 2013 at 05:20:51PM -0500, Richard Guy Briggs wrote: > > > static inline bool is_idle_task(const struct task_struct *p) > > { > > - return p->pid == 0; > > + return task_pid(p) == &init_struct_pid; > > } > > > I'll stick with task_pid_nr(p) == 0. > > We're going to probably switch to: > > return p->flags & PF_IDLE; > > Soon, because people are playing silly tricks and want normal threads > to temporarily appear to be the idle thread (idle time injection).
Ok, this addresses my concerns. I'll stay out of the way.
- RGB
-- Richard Guy Briggs <rbriggs@redhat.com> Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat Remote, Ottawa, Canada Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545
| |