Messages in this thread | | | Date | Thu, 19 Dec 2013 11:19:35 +0530 | From | Kishon Vijay Abraham I <> | Subject | Re: [PATCH v7 8/9] phy: add Broadcom Kona USB2 PHY driver |
| |
Hi Felipe,
On Wednesday 18 December 2013 09:55 PM, Felipe Balbi wrote: > On Tue, Dec 17, 2013 at 02:42:35PM -0500, Matt Porter wrote: >> Add a driver for the internal Broadcom Kona USB 2.0 PHY found >> on the BCM281xx family of SoCs. >> >> Signed-off-by: Matt Porter <mporter@linaro.org> > > Kishon, are you ok with this driver ?
yeah. Since this patch touches phy/Kconfig (and Makefile) and there is one more PHY driver to be merged that also modifies Kconfig there might be conflicts. So thought I should be taking this patch? > >> +static int bcm_kona_usb2_probe(struct platform_device *pdev) >> +{ >> + struct device *dev = &pdev->dev; >> + struct bcm_kona_usb *phy; >> + struct resource *res; >> + struct phy *gphy; >> + struct phy_provider *phy_provider; >> + >> + phy = devm_kzalloc(dev, sizeof(*phy), GFP_KERNEL); >> + if (!phy) >> + return -ENOMEM; >> + >> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> + phy->regs = devm_ioremap_resource(&pdev->dev, res); >> + if (IS_ERR(phy->regs)) >> + return PTR_ERR(phy->regs); >> + >> + platform_set_drvdata(pdev, phy); >> + >> + phy_provider = devm_of_phy_provider_register(dev, >> + of_phy_simple_xlate); >> + if (IS_ERR(phy_provider)) >> + return PTR_ERR(phy_provider); >> + >> + gphy = devm_phy_create(dev, &ops, NULL); >> + if (IS_ERR(gphy)) >> + return PTR_ERR(gphy); >> + >> + /* The Kona PHY supports an 8-bit wide UTMI interface */ >> + phy_set_bus_width(gphy, 8); >> + >> + phy_set_drvdata(gphy, phy); > > I think this set_drvdata() should be done before registering the > provider, no ?
hmm, right.
Thanks Kishon
| |