lkml.org 
[lkml]   [2013]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 04/18] perf tools: Introduce struct add_entry_iter
On Wed, Dec 18, 2013 at 02:21:12PM +0900, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@lge.com>
>
> There're some duplicate code when adding hist entries. They are
> different in that some have branch info or mem info but generally do
> same thing. So introduce new struct add_entry_iter and add callbacks
> to customize each case in general way.
>
> The new perf_evsel__add_entry() function will look like:
>
> iter->prepare_entry();
> iter->add_single_entry();
>
> while (iter->next_entry())
> iter->add_next_entry();
>
> iter->finish_entry();
>
> This will help further work like the cumulative callchain patchset.

cool, I was waiting for this one! I have another user
for it, I'll test by rebasing my code ;-)

thanks,
jirka


\
 
 \ /
  Last update: 2013-12-18 19:41    [W:0.130 / U:0.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site