Messages in this thread | | | Date | Tue, 17 Dec 2013 16:45:00 -0500 | From | Bradley Grove <> | Subject | Re: [RESEND][PATCH] scsi: esas2r: fix potential format string flaw |
| |
Acked-by: Bradley Grove <bgrove@attotech.com>
On 12/17/2013 01:27 PM, Kees Cook wrote: > This makes sure format strings cannot leak into the printk call via the > constructed buffer. > > Signed-off-by: Kees Cook <keescook@chromium.org> > --- > drivers/scsi/esas2r/esas2r_log.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/esas2r/esas2r_log.c b/drivers/scsi/esas2r/esas2r_log.c > index 9bf285df58dd..61fc19d296bd 100644 > --- a/drivers/scsi/esas2r/esas2r_log.c > +++ b/drivers/scsi/esas2r/esas2r_log.c > @@ -171,7 +171,7 @@ static int esas2r_log_master(const long level, > if (strlen(event_buffer) < buflen) > strcat(buffer, "\n"); > > - printk(event_buffer); > + printk("%s", event_buffer); > > spin_unlock_irqrestore(&event_buffer_lock, flags); > } >
| |