lkml.org 
[lkml]   [2013]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.5 087/103] dm table: fail dm_table_create on dm_round_up overflow
    Date
    3.5.7.28 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Mikulas Patocka <mpatocka@redhat.com>

    commit 5b2d06576c5410c10d95adfd5c4d8b24de861d87 upstream.

    The dm_round_up function may overflow to zero. In this case,
    dm_table_create() must fail rather than go on to allocate an empty array
    with alloc_targets().

    This fixes a possible memory corruption that could be caused by passing
    too large a number in "param->target_count".

    Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
    Signed-off-by: Mike Snitzer <snitzer@redhat.com>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    drivers/md/dm-table.c | 5 +++++
    1 file changed, 5 insertions(+)

    diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
    index d509f23..43e19b7 100644
    --- a/drivers/md/dm-table.c
    +++ b/drivers/md/dm-table.c
    @@ -215,6 +215,11 @@ int dm_table_create(struct dm_table **result, fmode_t mode,

    num_targets = dm_round_up(num_targets, KEYS_PER_NODE);

    + if (!num_targets) {
    + kfree(t);
    + return -ENOMEM;
    + }
    +
    if (alloc_targets(t, num_targets)) {
    kfree(t);
    t = NULL;
    --
    1.8.3.2


    \
     
     \ /
      Last update: 2013-12-17 21:01    [W:4.111 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site