Messages in this thread | | | Subject | Re: [PATCH 1/4] Create generic early_ioremap() support | From | Mark Salter <> | Date | Tue, 17 Dec 2013 13:45:38 -0500 |
| |
On Mon, 2013-12-16 at 09:48 +0800, Dave Young wrote: > On 11/27/13 at 09:44pm, Mark Salter wrote: > > This patch copies generic bits of x86 early_ioremap() support > > into a library for potential use by other architectures. > > > > Signed-off-by: Mark Salter <msalter@redhat.com> > > CC: Arnd Bergmann <arnd@arndb.de> > > CC: Ingo Molnar <mingo@kernel.org> > > CC: linux-arch@vger.kernel.org > > --- > > include/asm-generic/early_ioremap.h | 40 ++++++ > > lib/Kconfig | 3 + > > lib/Makefile | 1 + > > lib/early_ioremap.c | 243 > ++++++++++++++++++++++++++++++++++++ > > I do not understand why these should go to lib/, I feel it's slightly better > move them to mm/ > > ditto about lib/ioremap.c, ... >
I hadn't really thought about it. Putting these things in mm doesn't sound unreasonable, but lib seems to have become the place for a lot generic code which could also belong in mm, net, etc.
| |