lkml.org 
[lkml]   [2013]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/4] Create generic early_ioremap() support
From
Date
On Mon, 2013-12-16 at 09:48 +0800, Dave Young wrote:
> On 11/27/13 at 09:44pm, Mark Salter wrote:
> > This patch copies generic bits of x86 early_ioremap() support
> > into a library for potential use by other architectures.
> >
> > Signed-off-by: Mark Salter <msalter@redhat.com>
> > CC: Arnd Bergmann <arnd@arndb.de>
> > CC: Ingo Molnar <mingo@kernel.org>
> > CC: linux-arch@vger.kernel.org
> > ---
> > include/asm-generic/early_ioremap.h | 40 ++++++
> > lib/Kconfig | 3 +
> > lib/Makefile | 1 +
> > lib/early_ioremap.c | 243
> ++++++++++++++++++++++++++++++++++++
>
> I do not understand why these should go to lib/, I feel it's slightly better
> move them to mm/
>
> ditto about lib/ioremap.c, ...
>

I hadn't really thought about it. Putting these things in mm doesn't
sound unreasonable, but lib seems to have become the place for a lot
generic code which could also belong in mm, net, etc.




\
 
 \ /
  Last update: 2013-12-17 20:41    [W:0.108 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site