Messages in this thread | | | Date | Tue, 17 Dec 2013 08:37:03 -0800 | From | Josh Triplett <> | Subject | Re: [PATCH 1/2] drivers: ide: Include appropriate header file in ide-cd_verbose.c |
| |
On Tue, Dec 17, 2013 at 04:38:16PM +0530, Rashika Kheria wrote: > Include appropriate header file ide-cd.h in ide-cd_verbose.c because > function ide_cd_log_error() has its prototype declaration in ide-cd.h. > Also, include linux/ide.h because it contains certain declarations > necessary for including ide-cd.h. > > This eliminates the following warnings in ide-cd_verbose.c: > drivers/ide/ide-cd_verbose.c:251:6: warning: no previous prototype for ‘ide_cd_log_error’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/ide/ide-cd_verbose.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/ide/ide-cd_verbose.c b/drivers/ide/ide-cd_verbose.c > index 6490a2d..f079ca2 100644 > --- a/drivers/ide/ide-cd_verbose.c > +++ b/drivers/ide/ide-cd_verbose.c > @@ -9,7 +9,9 @@ > #include <linux/kernel.h> > #include <linux/blkdev.h> > #include <linux/cdrom.h> > +#include <linux/ide.h> > #include <scsi/scsi.h> > +#include "ide-cd.h" > > #ifndef CONFIG_BLK_DEV_IDECD_VERBOSE_ERRORS > void ide_cd_log_error(const char *name, struct request *failed_command, > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |