lkml.org 
[lkml]   [2013]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers: ptp: Include new header file in ptp_pch.c
On Mon, Dec 16, 2013 at 02:14:15AM +0530, Rashika Kheria wrote:
> ---
> drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h | 9 ---------
> .../net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 1 +
> drivers/ptp/ptp_pch.c | 1 +
> include/linux/ptp_pch.h | 16 ++++++++++++++++
> 4 files changed, 18 insertions(+), 9 deletions(-)
> create mode 100644 include/linux/ptp_pch.h

Instead of adding a random driver header into include/linux, I would
prefer that you just move the ptp_pch.c from drivers/ptp to
drivers/net/ethernet/oki-semi/pch_gbe. Then you can just include
pch_gbe.h directly.

Thanks,
Richard


\
 
 \ /
  Last update: 2013-12-16 10:21    [W:0.066 / U:1.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site