Messages in this thread | | | Subject | Re: [PATCH 1/3] Introduce FW_INFO* functions and messages | From | Joe Perches <> | Date | Mon, 16 Dec 2013 08:31:16 -0800 |
| |
On Mon, 2013-12-16 at 08:01 -0500, Prarit Bhargava wrote: > Sorry everyone, I was out on PTO for the past few weeks. > > > On 12/06/2013 07:30 AM, Matt Fleming wrote: > > On Thu, 05 Dec, at 07:55:03AM, Joe Perches wrote: > >> On Thu, 2013-12-05 at 11:30 +0000, Matt Fleming wrote: > >>> On Wed, 04 Dec, at 07:22:57PM, Arnd Bergmann wrote: > >>>> The other part I noticed about this particular patchset is that it's > >>>> not really "firmware" as such, but specifically PC wiht ACPI that > >>>> gets covered here. So rather than generalizing the code, another > >>>> option would be to narrow down the scope and make it > >>>> acpi_{warn,info,dbg} instead. > >>> > >>> Making this specific to ACPI runs the risk of people introducing a > >>> multitude of new logging functions for every subsystem, e.g. > >>> efi_{warn,info,dbg}. > >> > >> There are many subsystem specific logging functions: > > > > Surely that's further justification to not introduce any more. > > That's what I was thinking when I saw this discussion.
I have no problem with introducing more <subsystem>_<kern_level> functions/macros.
It can reduce overall object size quite a lot.
see commits like: 227842d1176019512d24236f7fb894f0fadd30d1
| |