Messages in this thread | | | Date | Sun, 15 Dec 2013 23:00:04 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] afs: proc cells and rootcell are writeable |
| |
On Wed, 20 Nov 2013 14:30:55 +0100 Pali Roh__r <pali.rohar@gmail.com> wrote:
> Both proc files are writeable and used for configuring cells. But > there is missing correct mode flag for writeable files. Without > this patch both proc files are read only. > > diff --git a/fs/afs/proc.c b/fs/afs/proc.c > index 526e4bb..276cb6e 100644 > --- a/fs/afs/proc.c > +++ b/fs/afs/proc.c > @@ -147,11 +147,11 @@ int afs_proc_init(void) > if (!proc_afs) > goto error_dir; > > - p = proc_create("cells", 0, proc_afs, &afs_proc_cells_fops); > + p = proc_create("cells", S_IFREG | S_IRUGO | S_IWUSR, proc_afs, &afs_proc_cells_fops); > if (!p) > goto error_cells; > > - p = proc_create("rootcell", 0, proc_afs, &afs_proc_rootcell_fops); > + p = proc_create("rootcell", S_IFREG | S_IRUGO | S_IWUSR, proc_afs, &afs_proc_rootcell_fops); > if (!p) > goto error_rootcell;
Please send a signed-off-by: for this, as per Documentation/SubmittingPatches, section 12.
David ack?
| |