Messages in this thread | | | Date | Sun, 15 Dec 2013 19:07:25 +0800 | From | Jiang Liu <> | Subject | Re: [PATCH v6 6/7] arm64, jump label: optimize jump label implementation |
| |
On 12/13/2013 11:52 PM, Steven Rostedt wrote: > On Fri, 13 Dec 2013 10:50:23 -0500 > Steven Rostedt <rostedt@goodmis.org> wrote: > >> On Fri, 13 Dec 2013 15:41:04 +0000 >> Will Deacon <will.deacon@arm.com> wrote: >> >>>> +#include <linux/kernel.h> >>>> +#include <linux/jump_label.h> >>>> +#include <asm/jump_label.h> >>>> +#include <asm/insn.h> >>>> + >>>> +#ifdef HAVE_JUMP_LABEL >>> >>> Slightly worrying... this should be CONFIG_HAVE_JUMP_LABEL, right? How did >>> you manage to test this code? >> >> In <linux/jump_label.h> we have: >> >> #if defined(CC_HAVE_ASM_GOTO) && defined(CONFIG_JUMP_LABEL) >> >> [...] >> >> # include <asm/jump_label.h> > > This also makes the include of <asm/jump_label.h> in the C file > redundant. > > -- Steve Thanks, Steve. Will remove the redundant include header file.
> >> # define HAVE_JUMP_LABEL >> #endif /* CC_HAVE_ASM_GOTO && CONFIG_JUMP_LABEL */ >> >> >> -- Steve >
| |