lkml.org 
[lkml]   [2013]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/5] xfs: factor prid related codes into xfs_get_initial_prid()
From
On Sat, Dec 14, 2013 at 7:20 PM, Jeff Liu <jeff.liu@oracle.com> wrote:
> On 12/14 2013 00:32 AM, Christoph Hellwig wrote:
>>> +static inline prid_t xfs_get_initial_prid(struct xfs_inode *dp)
>>> +{
>>> + if (dp->i_d.di_flags & XFS_DIFLAG_PROJINHERIT)
>>> + return xfs_get_projid(dp);
>>> + else
>>> + return XFS_PROJID_DEFAULT;
>>> +}
>>
>> You could skip the else here.
> Except that, I'd suggest we move this helper to proper header file with
> further refactoring in xfs_symlink(), and it could be a separate patch.
Good point, will apply it, thanks.

>
> Thanks,
> -Jeff



--
Regards,

Zhi Yong Wu


\
 
 \ /
  Last update: 2013-12-14 13:01    [W:0.036 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site