lkml.org 
[lkml]   [2013]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] xfs: factor prid related codes into xfs_get_initial_prid()
On 12/14 2013 00:32 AM, Christoph Hellwig wrote:
>> +static inline prid_t xfs_get_initial_prid(struct xfs_inode *dp)
>> +{
>> + if (dp->i_d.di_flags & XFS_DIFLAG_PROJINHERIT)
>> + return xfs_get_projid(dp);
>> + else
>> + return XFS_PROJID_DEFAULT;
>> +}
>
> You could skip the else here.
Except that, I'd suggest we move this helper to proper header file with
further refactoring in xfs_symlink(), and it could be a separate patch.

Thanks,
-Jeff


\
 
 \ /
  Last update: 2013-12-14 12:41    [W:4.242 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site