lkml.org 
[lkml]   [2013]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] ARM: dts: add board dts file for EXYNOS4412 based TINY4412 board
    Tomasz,
    Thanks for reviewing. I'll fix the patch description and style problems.


    Regards,
    Alex

    On Sun, Dec 15, 2013 at 2:57 AM, Tomasz Figa <tomasz.figa@gmail.com> wrote:
    > Hi Alex,
    >
    > On Friday 15 of November 2013 21:09:29 Alex Ling wrote:
    >> Add a minimal board dts file for EXYNOS4412 based FriendlyARM's
    >> TINY4412 board. This patch including adds the node to support
    >> peripherals like UART, SD card on SDMMC2 port, and this patch
    >> adds GPIO connected LEDS and configure its properties like
    >> following:
    >> LED1: use 'heartbeat' trigger, blinking while the board is running.
    >> LED4: use 'mmc0' trigger, on when mmc0 is accessing.
    >> LED2 and LED3 can be controlled from userspace.
    >
    > Well, all the LEDs can be controlled from userspace. The default trigger
    > is just the initial setting, which can be changed later by userspace.
    > It's just a general comment, not an issue with the patch, though.
    >
    > Anyway, you don't need such detailed patch description, as you can see
    > most of the things directly from the code. In case of this patch, just the
    > list of supported peripherals is fine, without going into minor details,
    > such as LED triggers.
    >
    > Also, please see my comments inline.
    >
    > [snip]
    >> diff --git a/arch/arm/boot/dts/exynos4412-tiny4412.dts b/arch/arm/boot/dts/exynos4412-tiny4412.dts
    >> new file mode 100644
    >> index 0000000..78ace14
    >> --- /dev/null
    >> +++ b/arch/arm/boot/dts/exynos4412-tiny4412.dts
    > [snip]
    >> + leds {
    >> + compatible = "gpio-leds";
    >
    > style: A blank line should be separating properties from nodes.
    >
    >> + led1 {
    >> + label = "led1:heart";
    >
    > Are the labels for this and the LEDs below related to the hardware?
    > I mean, the label should preferrably come from the board documentation,
    > or a label on the PCB next to the LED. Also they shouldn't represent
    > any particular use case, so you should remove the ":heart" suffix.
    >
    >> + gpios = <&gpm4 0 1>;
    >> + default-state = "off";
    >> + linux,default-trigger = "heartbeat";
    >> + };
    >
    > style: Subnodes should be separated with blank lines.
    >
    > Otherwise the patch looks fine.
    >
    > Best regards,
    > Tomasz
    >


    \
     
     \ /
      Last update: 2013-12-15 04:01    [W:6.723 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site