lkml.org 
[lkml]   [2013]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRE: [PATCH] drivers: hv: Mark the function hv_synic_free_cpu() as static in hv.c
Date


> -----Original Message-----
> From: Josh Triplett [mailto:josh@joshtriplett.org]
> Sent: Saturday, December 14, 2013 12:57 PM
> To: Rashika Kheria
> Cc: linux-kernel@vger.kernel.org; KY Srinivasan; Haiyang Zhang;
> devel@linuxdriverproject.org
> Subject: Re: [PATCH] drivers: hv: Mark the function hv_synic_free_cpu() as static
> in hv.c
>
> On Sat, Dec 14, 2013 at 07:00:06PM +0530, Rashika Kheria wrote:
> > This patch marks the function hv_synic_free_cpu() as static in hv.c
> > because it is not used outside this file.
> >
> > Thus, it also eliminates the following warning in hv.c:
> > drivers/hv/hv.c:304:6: warning: no previous prototype for ‘hv_synic_free_cpu’
> [-Wmissing-prototypes]
> >
> > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Thank you.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
>
> > drivers/hv/hv.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
> > index f0c5e07..bcb4950 100644
> > --- a/drivers/hv/hv.c
> > +++ b/drivers/hv/hv.c
> > @@ -301,7 +301,7 @@ err:
> > return -ENOMEM;
> > }
> >
> > -void hv_synic_free_cpu(int cpu)
> > +static void hv_synic_free_cpu(int cpu)
> > {
> > kfree(hv_context.event_dpc[cpu]);
> > if (hv_context.synic_event_page[cpu])
> > --
> > 1.7.9.5
> >
\
 
 \ /
  Last update: 2013-12-14 23:41    [W:0.036 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site