Messages in this thread | | | Date | Sat, 14 Dec 2013 12:57:52 -0800 | From | Josh Triplett <> | Subject | Re: [PATCH] drivers: input: Include appropriate header file in cyttsp_i2c_common.c |
| |
On Sat, Dec 14, 2013 at 07:08:22PM +0530, Rashika Kheria wrote: > This patch includes appropriate header file cyttsp4_core.h in > touchscreen/cyttsp_i2c_common.c because functions > cyttsp_i2c_read_block_data() and cyttsp_i2c_write_block_data() > have their prototype declaration in cyttsp4_core.h. > > Thus, it also eliminates the following warning in cyttsp_i2c_common.c: > drivers/input/touchscreen/cyttsp_i2c_common.c:34:5: warning: no previous prototype for ‘cyttsp_i2c_read_block_data’ [-Wmissing-prototypes] > drivers/input/touchscreen/cyttsp_i2c_common.c:64:5: warning: no previous prototype for ‘cyttsp_i2c_write_block_data’ [-Wmissing-prototypes] > > > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/input/touchscreen/cyttsp_i2c_common.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/input/touchscreen/cyttsp_i2c_common.c b/drivers/input/touchscreen/cyttsp_i2c_common.c > index 1d7b6f1..ccefa56 100644 > --- a/drivers/input/touchscreen/cyttsp_i2c_common.c > +++ b/drivers/input/touchscreen/cyttsp_i2c_common.c > @@ -31,6 +31,8 @@ > #include <linux/module.h> > #include <linux/types.h> > > +#include "cyttsp4_core.h" > + > int cyttsp_i2c_read_block_data(struct device *dev, u8 *xfer_buf, > u16 addr, u8 length, void *values) > { > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |