lkml.org 
[lkml]   [2013]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] drivers: rapidio: Include appropriate header file in rio-access.c
On Sat, Dec 14, 2013 at 06:16:28PM +0530, Rashika Kheria wrote:
> This patch includes appropriate header file linux/rio_drv.h in
> rio-access.c because functions __rio_local_read_config_8,
> __rio_local_read_config_16, __rio_local_read_config_32,
> __rio_local_write_config_8, __rio_local_write_config_16,
> __rio_local_write_config_32, rio_mport_read_config_8,
> rio_mport_read_config_16, rio_mport_read_config_32,
> rio_mport_write_config_8, rio_mport_write_config_16,
> rio_mport_write_config_32 and rio_mport_send_doorbell have their
> prototype declaration in linux/rio_drv.h.
>
> Thus, it also eliminates the following warning in rio-access.c:
>
> drivers/rapidio/rio-access.c:79:1: warning: no previous prototype for ‘__rio_local_read_config_8’ [-Wmissing-prototypes]
> drivers/rapidio/rio-access.c:80:1: warning: no previous prototype for ‘__rio_local_read_config_16’ [-Wmissing-prototypes]
> drivers/rapidio/rio-access.c:81:1: warning: no previous prototype for ‘__rio_local_read_config_32’ [-Wmissing-prototypes]
> drivers/rapidio/rio-access.c:82:1: warning: no previous prototype for ‘__rio_local_write_config_8’ [-Wmissing-prototypes]
> drivers/rapidio/rio-access.c:83:1: warning: no previous prototype for ‘__rio_local_write_config_16’ [-Wmissing-prototypes]
> drivers/rapidio/rio-access.c:84:1: warning: no previous prototype for ‘__rio_local_write_config_32’ [-Wmissing-prototypes]
> drivers/rapidio/rio-access.c:139:1: warning: no previous prototype for ‘rio_mport_read_config_8’ [-Wmissing-prototypes]
> drivers/rapidio/rio-access.c:140:1: warning: no previous prototype for ‘rio_mport_read_config_16’ [-Wmissing-prototypes]
> drivers/rapidio/rio-access.c:141:1: warning: no previous prototype for ‘rio_mport_read_config_32’ [-Wmissing-prototypes]
> drivers/rapidio/rio-access.c:142:1: warning: no previous prototype for ‘rio_mport_write_config_8’ [-Wmissing-prototypes]
> drivers/rapidio/rio-access.c:143:1: warning: no previous prototype for ‘rio_mport_write_config_16’ [-Wmissing-prototypes]
> drivers/rapidio/rio-access.c:144:1: warning: no previous prototype for ‘rio_mport_write_config_32’ [-Wmissing-prototypes]
> drivers/rapidio/rio-access.c:163:5: warning: no previous prototype for ‘rio_mport_send_doorbell’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

> drivers/rapidio/rio-access.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/rapidio/rio-access.c b/drivers/rapidio/rio-access.c
> index a3824ba..5e6c7eb 100644
> --- a/drivers/rapidio/rio-access.c
> +++ b/drivers/rapidio/rio-access.c
> @@ -11,6 +11,7 @@
> */
>
> #include <linux/rio.h>
> +#include <linux/rio_drv.h>
> #include <linux/module.h>
>
> /*
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2013-12-14 22:01    [W:0.079 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site