lkml.org 
[lkml]   [2013]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] drivers: edac: Mark the function amd64_decode_bus_error() as static in amd64_edac.c
On Sat, Dec 14, 2013 at 11:47:10PM +0530, Rashika Kheria wrote:
> My gcc version is 4.6.3. You can trigger these warnings by adding
> -Wmissing-prototypes to KBUILD_CFLAGS in the top-level Makefile, and

Actually, you don't even have to do that - you only need to build with
W=1:

make W=1 drivers/edac/amd64_edac.o

We already enable -Wmissing-prototypes as an additional compiler warning
when building objects with the W= switch.

> do a build with defconfig or allyesconfig. It will show all warnings
> of missing prototype.

Ok, gcc man page says this detects global functions without prototypes
in a header but I guess it can be used to detect needlessly global
functions too. :)

I'll pick up your three patches,

Thanks.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--


\
 
 \ /
  Last update: 2013-12-14 22:01    [W:0.089 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site